Skip to content

Feat/cluster access definitions #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

Feat/cluster access definitions #74

wants to merge 19 commits into from
+188 −1

Conversation

@makdeniss
Copy link

@makdeniss makdeniss commented Oct 16, 2025 •
edited
Loading

Changes

  • Old definitions files are properly removed when the path changes.
  • Definitions files are removed when the ClusterAccess resource is deleted.
  • Path updates now remove old definitions files correctly.
  • Deleting a ClusterAccess cleans up definitions files as expected.

The issue appears to be resolved.

vertex451 and others added 14 commits October 10, 2025 15:35
@vertex451
ensured that we have ClusterAccess CRD installed
8721eec
@vertex451
wait for CRD to be fully registered
e78ee20
@vertex451
addressed comments
d13952d
@vertex451
removed TOCTOU race
b5d4187
@renovate @vertex451
fix(deps): update module sigs.k8s.io/controller-runtime to v0.22.2 (#67)
483f358 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @vertex451
fix(deps): update module golang.org/x/text to v0.30.0 (#70)
44bd887 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@vertex451
Fix: relations nil pointer check (#68)
06d9d8c 
* added nil checks in relation resovling

On-behalf-of: @SAP [email protected]
Signed-off-by: Artem Shcherbatiuk <[email protected]>
@renovate @vertex451
fix(deps): update golang.org/x/exp digest to d2f985d (#71)
dfa9b29 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@vertex451
improved docs
e332a37
@vertex451
Merge branch 'main' of github.com:platform-mesh/kubernetes-graphql-ga…
093457e 
…teway into feat/script
@vertex451
Merge branch 'main' into feat/script
59ada28
@vertex451
removed testing script due for the simplicity of support
d374320
feat: cluster access definitions deletion (#69)
cde201f
feat: refine cluster access definitions deletion (#69)
9d9185b
@makdeniss makdeniss self-assigned this Oct 16, 2025
@makdeniss makdeniss added the good first issue Good for newcomers label Oct 16, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 16, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/cluster-access-definitions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2025 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ vertex451
❌ makdeniss

makdeniss seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

vertex451
vertex451 reviewed Oct 16, 2025
View reviewed changes
@vertex451
Copy link
Contributor

vertex451 commented Oct 21, 2025 •
edited
Loading

  1. Make sure the title is precise.
  2. Add description with the sections: Changes, Testing, any other section you think is helpful
  3. Answer comments if any
  4. Deal with CLA check, you should have "on behalf of" signature in case you use your personal github.
    Example here: platform-mesh/helm-charts@ccc0133
    Read this thread for more context: https://sap-btp.slack.com/archives/C0745NL10K0/p1732261714101609
    And there is a automation script from Angel that will add this thing into your commits.

Base automatically changed from feat/script to main October 21, 2025 09:11
@github-actions github-actions bot added the fix label Oct 22, 2025
@makdeniss makdeniss closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vertex451 vertex451 vertex451 left review comments

Assignees

@makdeniss makdeniss

Labels

feature fix good first issue Good for newcomers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@makdeniss @CLAassistant @vertex451